Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible remediation to ensure_oracle_gpgkey_installed rule #12323

Conversation

mrkanon
Copy link
Contributor

@mrkanon mrkanon commented Aug 21, 2024

Description:

Added

  • Ansible remediation
  • Tests

Rationale:

In the task filling gaps in OL9 automation, the rule ensure_oracle_gpgkey_installed has a remediation deficit with ansible. I adapted the ensure_redhat_gpgkey_installed remediation and tests for Oracle.

For ensure_oracle_gpgkey_installed rule

Signed-off-by: Armando Acosta <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 21, 2024
Copy link

openshift-ci bot commented Aug 21, 2024

Hi @mrkanon. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Aug 21, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12323
This image was built from commit: 76fac4e

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12323

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12323 make deploy-local

#
# platform = multi_platform_ol

rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-oracle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fails because of the missing end-of-file in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I updated the test.

@jan-cerny jan-cerny self-assigned this Aug 26, 2024
@jan-cerny jan-cerny added this to the 0.1.75 milestone Aug 26, 2024
@jan-cerny jan-cerny added the Ansible Ansible remediation update. label Aug 26, 2024
@mrkanon mrkanon force-pushed the ansible-ensure_oracle_gpgkey_installed branch from e734c30 to 76fac4e Compare August 26, 2024 18:10
Copy link

codeclimate bot commented Aug 26, 2024

Code Climate has analyzed commit 76fac4e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit 061097a into ComplianceAsCode:master Aug 27, 2024
86 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants