-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ansible remediation to ensure_oracle_gpgkey_installed rule #12323
Add ansible remediation to ensure_oracle_gpgkey_installed rule #12323
Conversation
For ensure_oracle_gpgkey_installed rule Signed-off-by: Armando Acosta <[email protected]>
Hi @mrkanon. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
# | ||
# platform = multi_platform_ol | ||
|
||
rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-oracle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI fails because of the missing end-of-file in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I updated the test.
Signed-off-by: Armando Acosta <[email protected]>
e734c30
to
76fac4e
Compare
Code Climate has analyzed commit 76fac4e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Description:
Added
Rationale:
In the task filling gaps in OL9 automation, the rule
ensure_oracle_gpgkey_installed
has a remediation deficit with ansible. I adapted theensure_redhat_gpgkey_installed
remediation and tests for Oracle.