Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 11909 #12318

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

a-skr
Copy link
Contributor

@a-skr a-skr commented Aug 21, 2024

Description:

fix a bug in debian standard profile that was causing openscap exiting on an assertion.

Rationale

  • Fixes Assertion failure with Debian Bookworm #11909

  • As debian 12 openssh version is 9.2, sshd_keep_alive_0 should be replaced with sshd_keep_alive.

  • adding the rule satisfies the dependencies of sshd_set_timeout rule. The dependency was previously missing (as a consequence, the scanner exited with an assertion)

As debian 12 openssh version is 9.2, sshd_keep_alive_0 should be
replaced with sshd_keep_alive.
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 21, 2024
Copy link

openshift-ci bot commented Aug 21, 2024

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12318
This image was built from commit: 60036d9

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12318

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12318 make deploy-local

Copy link

codeclimate bot commented Aug 21, 2024

Code Climate has analyzed commit 60036d9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added Debian Debian product related. Update Profile Issues or pull requests related to Profiles updates. labels Aug 26, 2024
@marcusburghardt marcusburghardt added this to the 0.1.75 milestone Aug 26, 2024
@marcusburghardt marcusburghardt self-assigned this Aug 26, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt marcusburghardt merged commit 0202d08 into ComplianceAsCode:master Aug 26, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debian Debian product related. needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure with Debian Bookworm
2 participants