Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt black #28

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Adopt black #28

merged 3 commits into from
Jan 30, 2023

Conversation

cletomartin
Copy link
Collaborator

@cletomartin cletomartin commented Jan 26, 2023 •
edited
Loading

What

Replace yapf with black.

Why

  • black and flake8 can coexist easily
  • Using just black people will be able to contribute to the project by adopting a simpler and automatic code linter, with less configuration needed.

How

  • Replace it in pre-commit and also update docs.

Context

ComplianceAsCode/auditree-framework#149

@cletomartin cletomartin force-pushed the adopt-black branch 2 times, most recently from f0ed9c2 to dc4c145 Compare January 26, 2023 19:22
@cletomartin cletomartin marked this pull request as ready for review January 27, 2023 11:03
@cletomartin cletomartin mentioned this pull request Jan 27, 2023
Merged
1 task
drsm79
drsm79 approved these changes Jan 29, 2023
View reviewed changes
Copy link

@drsm79 drsm79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding isort too

@cletomartin cletomartin merged commit 47852e2 into main Jan 30, 2023
@cletomartin cletomartin deleted the adopt-black branch January 30, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drsm79 drsm79 drsm79 approved these changes

@alfinkel alfinkel Awaiting requested review from alfinkel alfinkel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cletomartin @drsm79