Remove creds requirement when in local repo mode #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsm79
reviewed
Sep 3, 2020
harvest/cli.py
Outdated
| @@ -68,9 +68,10 @@ def _init_arguments(self): | |||
| def _validate_arguments(self, args): | |||
| if args.repo == 'local': | |||
| if not args.repo_path: | |||
| return 'ERROR: --repo-path expected for "local" mode' | |||
| return 'ERROR: --repo-path expected when using local repo mode' | |||
alfinkel
force-pushed
the
17-no-creds-for-local-repomode
branch
from
0208ebc to
fed482e
Compare
drsm79
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Creds are no longer required when running in local repo mode.
Why
Local repo mode doesn't need creds because the repo is local and no validation is being performed so Harvest shouldn't expect a credentials file when running in this mode.
How
Test
--repo-path. Confirmed creds are expected and used.--repo-path. Confirmed creds are expected and used.Context
Fixes #17