Fix bug introdued with new memory environment variables #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hacked this logic (#1283, #1292) in when struggling with some T2T alignments on Slurm, but clearly didn't test it enough since it completely broke cactus on AWS/MESOS. The reason is that it's using (and int-casting)
options.maxMemoryandoptions.defaultMemoryfrom Toil, which default toNoneon AWS/MESOS (but not single machine and slurm where I was testing).Anyway, this PR should fix it, buy handling None values (and making sure that passed-in values are properly parsed).