Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer for [field: ObservableProperty] uses from auto-properties #735

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Add analyzer for [field: ObservableProperty] uses from auto-properties #735

merged 2 commits into from
Jul 22, 2023

Conversation

Sergio0694
Copy link
Member

Closes #734

This PR adds a new analyzer to emit a diagnostic when using [field: ObservableProperty] from an auto-property.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Jul 10, 2023
@Sergio0694 Sergio0694 mentioned this pull request Jul 11, 2023
Merged
@Sergio0694 Sergio0694 force-pushed the dev/field-targeted-observableproperty branch from 62e7419 to 12defea Compare July 21, 2023 10:46
@Sergio0694 Sergio0694 force-pushed the dev/field-targeted-observableproperty branch from 12defea to 4c8f27b Compare July 21, 2023 10:50
@Sergio0694 Sergio0694 merged commit e512411 into main Jul 22, 2023
@Sergio0694 Sergio0694 deleted the dev/field-targeted-observableproperty branch July 22, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an analyzer for [field: ObservableProperty] uses
1 participant
@Sergio0694