Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AOT and single file analyzers #665

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Enable AOT and single file analyzers #665

merged 1 commit into from
Apr 20, 2023

Conversation

Sergio0694
Copy link
Member

This PR enables the AOT and single file analyzers.
There are no new warnings at this time.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added the build 🔥 Some changes or issues related to build infrastructure label Apr 12, 2023
agocke
agocke approved these changes Apr 12, 2023
View reviewed changes
Copy link

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This may get simpler when dotnet/sdk#31284 is fixed

src/Directory.Build.targets
<IsTrimmable>true</IsTrimmable>
<EnableTrimAnalyzer>true</EnableTrimAnalyzer>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically unnecessary as IsTrimmable implies this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping them for now to be explicit, but will definitely be doing another PR once dotnet/sdk#31284 is available and just use that new IsAotCompatible property, looks super nice! Looking forwards to it 😄

@Sergio0694 Sergio0694 merged commit ceba207 into main Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/enable-more-trimming-analyzers branch April 20, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@agocke agocke agocke approved these changes

Assignees
No one assigned
Labels
build 🔥 Some changes or issues related to build infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sergio0694 @agocke @Arlodotexe