Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [field:] and [property:] support for [RelayCommand] methods #630

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Add [field:] and [property:] support for [RelayCommand] methods #630

merged 6 commits into from
Mar 9, 2023

Conversation

Sergio0694
Copy link
Member

Closes #599

@Youssef1313 do you mind also taking a quick look whenever you have time? Thank you! 😄

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Mar 8, 2023
@Sergio0694 Sergio0694 force-pushed the dev/relay-command-attribute-forwarding branch from 60cb7bf to 13ce990 Compare March 8, 2023 19:19
Arlodotexe
Arlodotexe approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious issues. Looks good! 🚀

@Sergio0694 Sergio0694 merged commit 974e819 into main Mar 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/relay-command-attribute-forwarding branch March 9, 2023 12:52
@Sergio0694 Sergio0694 mentioned this pull request Mar 9, 2023
Merged
@Sergio0694 Sergio0694 mentioned this pull request Nov 13, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
feature 💡 A new feature being implemented mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
No open projects
8.2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom field and property attributes for [RelayCommand]
3 participants
@Sergio0694 @Arlodotexe @Youssef1313