Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target to fix analyzers on legacy .csproj projects #541

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Dec 17, 2022

Closes #540
Closes #495

This PR adds a new target to remove duplicate analyzers when running on legacy style .csproj projects.

Note: this does fix build errors, but IntelliSense is completely broken. Projects build but generated code isn't visible and is marked as errors. Analyzer warnings only show up in the output console but not in IntelliSense. Members referenced by generated code show up as unreferenced. The analyzers node in solution explorer is just completely empty and no analyzer is visible at all, so it's also impossible to inspect the generated code.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added build 🔥 Some changes or issues related to build infrastructure next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels Dec 17, 2022
@Sergio0694 Sergio0694 merged commit 2a47127 into main Dec 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/multi-target-legacy-support branch December 19, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔧 PRs fixing a discovered bug build 🔥 Some changes or issues related to build infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVVM Toolkit generators are broken on legacy style .csproj projects Compilation Error on .NET Framework
1 participant