Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Stream.ReadExactly on .NET 7 #535

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Use Stream.ReadExactly on .NET 7 #535

merged 2 commits into from
Dec 13, 2022

Conversation

Sergio0694
Copy link
Member

"For the .NET 7 target Stream.ReadExactly could be used. It boils down the be almost a one-liner."

Originally posted by @gfoidl in #520 (comment)

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements high-performance 🚂 Issues/PRs for the HighPerformance package labels Dec 13, 2022
@Sergio0694 Sergio0694 added the introduce breaking changes 💥 This change would be a breaking change label Dec 13, 2022
@Sergio0694 Sergio0694 merged commit 98aff98 into main Dec 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/stream-read-exactly branch December 13, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
high-performance 🚂 Issues/PRs for the HighPerformance package introduce breaking changes 💥 This change would be a breaking change optimization ☄ Performance or memory usage improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694