Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analyzer for incorrect [INotifyPropertyChanged] and [ObservableObject] use #531

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Add analyzer for incorrect [INotifyPropertyChanged] and [ObservableObject] use #531

merged 3 commits into from
Dec 12, 2022

Conversation

Sergio0694
Copy link
Member

Closes #530

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Dec 11, 2022
Arlodotexe
Arlodotexe approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple typos, otherwise looks good

src/CommunityToolkit.Mvvm.SourceGenerators/Diagnostics/DiagnosticDescriptors.cs Outdated Show resolved Hide resolved
src/CommunityToolkit.Mvvm.SourceGenerators/Diagnostics/DiagnosticDescriptors.cs Outdated Show resolved Hide resolved
@Sergio0694 Sergio0694 merged commit aa4ff30 into main Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/base-attribute-analyzer branch December 12, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add analyzer to warn when [INotifyPropertyChanged] & co. are used when not needed
2 participants
@Sergio0694 @Arlodotexe