Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Unsafe.SizeOf<T>() with sizeof(T) #511

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

Sergio0694
Copy link
Member

This PR suppresses CS8500 in the solution and uses sizeof(T) for all size-of expressions instead of Unsafe.SizeOf<T>().

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added the maintenance ⚙️ Some regular maintenance updates label Nov 23, 2022
@Sergio0694 Sergio0694 merged commit 2b3e604 into main Nov 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/use-language-unsafe branch November 23, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance ⚙️ Some regular maintenance updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant