Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 7 TFM to HighPerformance target, switch to C# 11 #481

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

Sergio0694
Copy link
Member

This PR introduces the following changes:

  • Adds the .NET 7 TFM to the HighPerformance package
  • Removes the Span<T> trick from the ref-like types, and uses ref fields instead
  • Enables trimming analyzers in the HighPerformance package again
  • Enables C# 11 for the whole solution
  • Also uses some C# 11 sugar where needed

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added build 🔥 Some changes or issues related to build infrastructure by design Some behavior that is intended and not an issue improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change maintenance ⚙️ Some regular maintenance updates next preview ✈️ This changes will be available in the upcoming preview nuget 📦 Changes or issues related to NuGet publishing optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit high-performance 🚂 Issues/PRs for the HighPerformance package labels Oct 26, 2022
@Sergio0694 Sergio0694 merged commit e489e32 into main Oct 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/net7-hp branch October 27, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 Some changes or issues related to build infrastructure by design Some behavior that is intended and not an issue high-performance 🚂 Issues/PRs for the HighPerformance package improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change maintenance ⚙️ Some regular maintenance updates mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview nuget 📦 Changes or issues related to NuGet publishing optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants