Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable explicit attribute forwarding for [ObservableProperty] #449

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Enable explicit attribute forwarding for [ObservableProperty] #449

merged 6 commits into from
Sep 28, 2022

Conversation

Sergio0694
Copy link
Member

Closes #413

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added the feature 💡 A new feature being implemented label Sep 20, 2022
@Sergio0694 Sergio0694 changed the title Dev/forwarded property attributes Enable explicit attribute forwarding for [ObservableProperty] Sep 20, 2022
@Sergio0694 Sergio0694 mentioned this pull request Sep 20, 2022
Closed
@Sergio0694 Sergio0694 force-pushed the dev/forwarded-property-attributes branch from 4bd9539 to 50e7780 Compare September 20, 2022 18:16
@Sergio0694 Sergio0694 force-pushed the dev/forwarded-property-attributes branch from 4e41297 to 293a230 Compare September 20, 2022 21:16
@Sergio0694 Sergio0694 marked this pull request as ready for review September 20, 2022 21:16
@Sergio0694 Sergio0694 force-pushed the dev/forwarded-property-attributes branch from 293a230 to da85c74 Compare September 20, 2022 22:47
@Sergio0694 Sergio0694 force-pushed the dev/forwarded-property-attributes branch from da85c74 to 213c876 Compare September 28, 2022 14:35
@Sergio0694 Sergio0694 merged commit 982debb into main Sep 28, 2022
@Sergio0694 Sergio0694 deleted the dev/forwarded-property-attributes branch September 28, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerdude powerdude powerdude left review comments

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
feature 💡 A new feature being implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom property attributes for [ObservableProperty]
3 participants
@Sergio0694 @powerdude @Arlodotexe