Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aka.ms links to MVVM generator diagnostics #326

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Sergio0694
Copy link
Member

This PR adds aka.ms links to the MVVM Toolkit diagnostics.
The links will redirect to the new docs added in MicrosoftDocs/CommunityToolkit#113.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added documentation 📃 Some proposed change related to documentation mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Jun 28, 2022
Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice but I think docs are not yet updated!? Links are 404'ing

Also, the previous link https://aka.ms/mvvmtoolkit/error and the parent link https://aka.ms/mvvmtoolkit/errors are not working!

You could redirect https://aka.ms/mvvmtoolkit/error to https://aka.ms/mvvmtoolkit/errors and show all the errors or landing page in the parent link.

Just a UX suggestion!

@Sergio0694
Copy link
Member Author

Yeah none of the links are active yet, we still need to finish publishing the docs 🙂

@Sergio0694 Sergio0694 merged commit 43bafc5 into main Jul 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/add-diagnostics-links branch July 6, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📃 Some proposed change related to documentation mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants