Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic for duplicate ICommand-s in base types #277

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Add diagnostic for duplicate ICommand-s in base types #277

merged 1 commit into from
Jun 1, 2022

Conversation

Sergio0694
Copy link
Member

Closes #274

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added improvements ✨ Improvements to an existing functionality next preview ✈️ This changes will be available in the upcoming preview mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels May 27, 2022
@Sergio0694 Sergio0694 merged commit 8742886 into main Jun 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/duplicate-base-icommand-diagnostics branch June 1, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
improvements ✨ Improvements to an existing functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No diagnostic is emitted for duplicate commands across inherited types
2 participants
@Sergio0694 @Arlodotexe