Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [ICommand] CanExecute with inherited generated property #258

Merged
merged 1 commit into from
May 24, 2022
Merged

Fix [ICommand] CanExecute with inherited generated property #258

merged 1 commit into from
May 24, 2022

Conversation

Sergio0694
Copy link
Member

Closes #257

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels May 20, 2022
@Sergio0694 Sergio0694 merged commit d299dfd into main May 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/fix-observableproperty-inherited-canexecute branch May 24, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error MVVMTK0009
2 participants
@Sergio0694 @Arlodotexe