Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source generators culture invariant #249

Merged
merged 1 commit into from
May 10, 2022
Merged

Make source generators culture invariant #249

merged 1 commit into from
May 10, 2022

Conversation

Sergio0694
Copy link
Member

Closes #230

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels May 9, 2022
@Sergio0694 Sergio0694 requested a review from Arlodotexe May 9, 2022 19:46
@Sergio0694 Sergio0694 merged commit 73e85b4 into main May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/culture-invariant-generators branch May 10, 2022 12:03
@Sergio0694 Sergio0694 mentioned this pull request May 21, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

Assignees
No one assigned
Labels
bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview priority 🚩 An issue or change that has priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Generator is not working as expected in Turkish OS
1 participant
@Sergio0694