Revamp observable collection APIs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
introduce breaking changes 💥
Sergio0694
force-pushed
the
dev/improve-collections
branch
from
5c9a731
to
eda464a
Compare
Sergio0694
force-pushed
the
dev/improve-collections
branch
4 times, most recently
from
09fbb92
to
f6167d3
Compare
|
Marking this as ready for review, it's in a good state now and we should include this in Preview3 to get folks to try it out. We can always keep refining things with additional feedback from the community, and what's here is better than main anyway 😊 |
|
@Sergio0694 did you finish updating the sample for this or is that still being worked on? Just wondering if any has changed coming out of that yet or not or if that's the next step? |
|
@michael-hawker Sample and docs are working in progress, finished them up now 🙂 |
Arlodotexe
reviewed
Apr 6, 2022
CommunityToolkit.Mvvm/Collections/ObservableGroupedCollectionExtensions.cs
Show resolved
Hide resolved
CommunityToolkit.Mvvm/Collections/ObservableGroupedCollectionExtensions.cs
Show resolved
Hide resolved
CommunityToolkit.Mvvm/Collections/ReadOnlyObservableGroupedCollection{TKey,TElement}.cs
Show resolved
Hide resolved
CommunityToolkit.Mvvm/Collections/ReadOnlyObservableGroupedCollection{TKey,TElement}.cs
Show resolved
Hide resolved
CommunityToolkit.Mvvm/Collections/ReadOnlyObservableGroupedCollection{TKey,TElement}.cs
Show resolved
Hide resolved
tests/CommunityToolkit.Mvvm.UnitTests/Collections/Test_ReadOnlyObservableGroupedCollection.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Mvvm.UnitTests/Collections/Test_ReadOnlyObservableGroupedCollection.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Mvvm.UnitTests/Collections/Test_ReadOnlyObservableGroupedCollection.cs
Show resolved
Hide resolved
Sergio0694
force-pushed
the
dev/improve-collections
branch
from
324f7c0
to
d1e75b9
Compare
Sergio0694
force-pushed
the
dev/improve-collections
branch
from
9f4420f
to
b897947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168.
Discussion on the changes should go in the linked issue, let's centralize that there and just keep PR reviews here.