Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [ObservableRecipient] with inherited base attributes #110

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

Sergio0694
Copy link
Member

Fixes #109

This PR makes this code compile and run correctly:

[ObservableObject]
public partial class BaseViewModel
{
}

[ObservableRecipient]
public partial class MyViewModel : BaseViewModel
{
}

@Sergio0694 Sergio0694 added next preview ✈️ This changes will be available in the upcoming preview mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels Feb 14, 2022
@Sergio0694 Sergio0694 force-pushed the dev/fix-observable-recipient-attribute-inheritance branch from 5c11191 to 4ca716f Compare February 14, 2022 20:43
@Sergio0694 Sergio0694 force-pushed the dev/fix-observable-recipient-attribute-inheritance branch from 4ca716f to c1cb029 Compare February 22, 2022 19:00
@Sergio0694 Sergio0694 merged commit d9c315c into main Feb 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/fix-observable-recipient-attribute-inheritance branch February 28, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: MVVMTK0005 base class annotation
3 participants