-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled deterministic builds. #3309
Conversation
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
c49cb3c
to
9d92cb2
Compare
@azchohfi looks like this fails the CI. |
9d92cb2
to
5fe896e
Compare
5fe896e
to
b4a558f
Compare
@Kyaa-dost want to just double-check you can build and run the Sample App on your machine with this change and we'll merge after? |
It is still missing some green checks for the Controls, the DataGrid and the GazeInput projects. The Controls and DataGrid are known, since they are missing the pdbs for the design projects, but the GazeInput is warning about a missing pdb for a winmd. @clairernovotny do you know if this is a false positive on NuGet Package Explorer, maybe? |
I didn't see the missing pdb for the winmd... I thought it was a false positive since we do have the pdbs for the runtimes: |
Why is that generating a full pdb? If it's portable it should be a lot smaller... |
why is it being built per architecture? |
Ah, right, it's C++ :) I would exclude the full PDB, there's nothing you can do there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @azchohfi and performing as expected 🚀🚀
CC: @michael-hawker
Fixes #3308
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Builds are not deterministic (https://github.com/clairernovotny/DeterministicBuilds)
What is the new behavior?
Builds are deterministic.
PR Checklist
Please check if your PR fulfills the following requirements: