Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeaderedControls #109

Merged
merged 13 commits into from
Jul 10, 2023
Merged

HeaderedControls #109

merged 13 commits into from
Jul 10, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 requested a review from michael-hawker July 6, 2023 12:56
michael-hawker
michael-hawker reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for bringing these over! Agree we should just have a single package for all these 'light-weight' helpers. Wonder if we're missing any at this point... 😋

Couple of small comments.

components/HeaderedControls/src/HeaderedContentControl/HeaderedContentControl.xaml Outdated Show resolved Hide resolved
components/HeaderedControls/tests/HeaderedControls.Tests.projitems Outdated Show resolved Hide resolved
components/HeaderedControls/samples/HeaderedTreeView.md Outdated Show resolved Hide resolved
@niels9001
Copy link
Collaborator Author

@michael-hawker I think I addressed your feedback :-). Added the same tests that are normally generated by default.

michael-hawker
michael-hawker requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor fixes needed, otherwise looks good. I'll push a fix for the WUX/MUXC issue though quick as I tested locally.

components/HeaderedControls/samples/Assets/Sunny.png Outdated Show resolved Hide resolved
components/HeaderedControls/samples/HeaderedTreeViewSample.xaml Show resolved Hide resolved
components/HeaderedControls/samples/HeaderedTreeViewSample.xaml.cs Outdated Show resolved Hide resolved
components/HeaderedControls/samples/HeaderedTreeViewSample.xaml Outdated Show resolved Hide resolved
michael-hawker and others added 2 commits July 7, 2023 16:32
@Arlodotexe Arlodotexe mentioned this pull request Jul 17, 2023
Closed
@michael-hawker michael-hawker mentioned this pull request Jul 10, 2023
Merged
@michael-hawker
Copy link
Member

Thanks @Arlodotexe for fixing that!

@michael-hawker michael-hawker merged commit bea1c71 into main Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/headeredcontrols branch July 10, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Toolkit 8.x
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niels9001 @michael-hawker @Arlodotexe