Skip to content

Commit

Permalink
Merge branch 'uwp-net8-windows' of https://github.com/CommunityToolki…
Browse files Browse the repository at this point in the history
…t/Windows into uwp-net8-windows
  • Loading branch information
Arlodotexe committed Dec 13, 2024
2 parents b063c55 + 29e9b08 commit 62c267d
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# See https://github.com/devcontainers/images/tree/main/src/dotnet for image choices
FROM mcr.microsoft.com/vscode/devcontainers/dotnet:8.0
FROM mcr.microsoft.com/vscode/devcontainers/dotnet:9.0

# [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
ARG NODE_VERSION="none"
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"args": {
// Update 'VARIANT' to pick a .NET Core version: 3.1, 5.0, 6.0
// Append -bullseye or -focal to pin to an OS version.
"VARIANT": "8.0",
"VARIANT": "9.0",
// Options
"NODE_VERSION": "lts/*"
}
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ on:
merge_group:

env:
DOTNET_VERSION: ${{ '8.0.201' }}
DOTNET_INSTALL_DIR: dotnet-install
DOTNET_ROOT: dotnet-install
DOTNET_VERSION: ${{ '9.0.x' }}
ENABLE_DIAGNOSTICS: true
MSBUILD_VERBOSITY: normal
#COREHOST_TRACE: 1
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<ItemGroup Condition="'$(Configuration)' == 'Release'">
<PackageReference Include="NuGet.Build.Tasks.Pack" Version="6.7.0" PrivateAssets="all" Pack="false" />
<PackageReference Include="NuGet.Build.Tasks.Pack" Version="6.12.1" PrivateAssets="all" Pack="false" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public sealed partial class ResourceNameToResourceStringConverter : IValueConver
#if WINAPPSDK && !HAS_UNO
return _resourceManager.MainResourceMap.TryGetValue(valueAsString).ValueAsString;
#else
return _resourceLoader.GetString(valueAsString);
return _resourceLoader.GetString(valueAsString) ?? string.Empty;
#endif
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ static StringExtensions()
if (uiContext != null)
{
var resourceLoader = ResourceLoader.GetForUIContext(uiContext);
return resourceLoader.GetString(resourceKey);
return resourceLoader?.GetString(resourceKey) ?? string.Empty;
}
else
{
return ResourceLoader.GetForCurrentView().GetString(resourceKey);
return ResourceLoader.GetForCurrentView().GetString(resourceKey) ?? string.Empty;
}
}
#endif
Expand Down
2 changes: 1 addition & 1 deletion components/Media/src/Dependencies.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<!-- WinUI 2 / UWP -->
<ItemGroup Condition="'$(IsUwp)' == 'true'">
<PackageReference Include="Win2D.uwp" Version="1.28.0" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.6.0" />
</ItemGroup>

<!-- WinUI 3 / WinAppSdk -->
Expand Down
2 changes: 1 addition & 1 deletion tooling

0 comments on commit 62c267d

Please sign in to comment.