-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable .NET 8 for uwp MultiTarget, upgrade packages #235
base: main
Are you sure you want to change the base?
Conversation
…to head, removed redundant RuntimeIdentifiers definition on libraries.
It would appear that adding the modern .NET for UWP TFM results in our gallery app being unbuildable in uap mode:
Starting with the 10.0.20348 SDK, the version of the tasks assembly is always 0.0.0.0, which is why VS can't tell the different newer versions apart. An issue has been filed for the platform here (thanks to @Sergio0694 for helping here). In the meantime, we'll have to employ a workaround to get the gallery buildable again. The code should be functionally identical to Since this is just an issue with Visual Studio, the workaround we're looking at is to disable modern .NET for UWP for local development and only enable it for build in the CI. When the issue is resolved, we can enable it again for local testing and build. |
Looks like this has fixed our problem with Sample and Source component projects not compiling in Visual Studio, but similar issues remain on the head itself. The package A few observations: As of 218a656, building the Sample Gallery for uwp results in:
If we revert 7625ac5 and only include this package on modern .net (not uap), we get the error message:
Removing this package reference entirely results in an error similar to the latest commit:
|
Seems like a proper fix will require a bugfix from the platform, we'll need to continue searching for a workaround here. 218a656 was good progress and did fix some things, but we're finding that the changes here are still causing problems when building the UWP head. Locally, when running a build in VS with modern .NET on UWP seemingly completely removed (no TFMs, no
Main builds fine, so there's additional changes in this branch that are causing this. Investigating. |
464a866
to
35b9e39
Compare
…and props files which use it
925bf57
to
00974a2
Compare
…conflicting with Uno Bootstrapper version
…ove support for out-of-support net6.0-windows* and net7.0-windows* TFMs.
…n Microsoft.Xaml.Behaviors.WinUI.Managed 3.0.0-preview1
For components that declare a
uwp
MultiTarget, this PR:net8.0-windows10.0.26100.0
TFM alongside the existinguap10.0.17763