-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed png asset workaround for library projects #129
Conversation
Cool, will test this out, does it resolve CommunityToolkit/Windows#197 as well with the change-over from the uno work-around or does that require further investigation? |
Oh, wait this one is still broken and appears to be looking in the wrong place: HeaderdContentControl doc... Miss this project maybe @Arlodotexe? |
This is just for the PNG files, the markdown requires further investigation since they enter the build process differently. |
@Arlodotexe quick check as I have a new test in the SG and this is changing the icon path: This is expected and proper now, right? I'll just have to update the test in my branch to match this new behavior? |
Oh, I didn't check the single-experiment head... does the IconPath output need to change here? |
Need to check single-component head
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally for the Single-Component Head now too, looks great. IconPath I think is only used by the all-up app, so think I've answered my own question.
Yep, this is the change we made to the source-generated icon path. |
This PR closes #100, fixing an issue where png files included in the component sample library weren't showing in the sample app.
Now that unoplatform/uno#2502 is closed, we no longer need the library asset workaround for these files, and can include them in the csproj as library assets instead.