Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed png asset workaround for library projects #129

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Arlodotexe
Copy link
Member

This PR closes #100, fixing an issue where png files included in the component sample library weren't showing in the sample app.

Now that unoplatform/uno#2502 is closed, we no longer need the library asset workaround for these files, and can include them in the csproj as library assets instead.

@Arlodotexe Arlodotexe added bug 🐛 Something isn't working enhancement New feature or request sample app 🖼 Uno Issues related to Uno Platform labels Aug 30, 2023
@Arlodotexe Arlodotexe self-assigned this Aug 30, 2023
@michael-hawker
Copy link
Member

Cool, will test this out, does it resolve CommunityToolkit/Windows#197 as well with the change-over from the uno work-around or does that require further investigation?

@michael-hawker
Copy link
Member

So far seems to fix 197 as well for the sample code/XAML in UWP:

image

🎉🎉🎉

@michael-hawker
Copy link
Member

Oh, wait this one is still broken and appears to be looking in the wrong place:

image

HeaderdContentControl doc... Miss this project maybe @Arlodotexe?

@Arlodotexe
Copy link
Member Author

Cool, will test this out, does it resolve CommunityToolkit/Windows#197 as well with the change-over from the uno work-around or does that require further investigation?

This is just for the PNG files, the markdown requires further investigation since they enter the build process differently.

michael-hawker
michael-hawker previously approved these changes Aug 30, 2023
@michael-hawker
Copy link
Member

@Arlodotexe quick check as I have a new test in the SG and this is changing the icon path:

image

This is expected and proper now, right? I'll just have to update the test in my branch to match this new behavior?

@michael-hawker
Copy link
Member

Oh, I didn't check the single-experiment head... does the IconPath output need to change here?

@michael-hawker michael-hawker dismissed their stale review August 30, 2023 14:50

Need to check single-component head

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally for the Single-Component Head now too, looks great. IconPath I think is only used by the all-up app, so think I've answered my own question.

@Arlodotexe
Copy link
Member Author

@Arlodotexe quick check as I have a new test in the SG and this is changing the icon path:

image

This is expected and proper now, right? I'll just have to update the test in my branch to match this new behavior?

Yep, this is the change we made to the source-generated icon path.

@michael-hawker michael-hawker merged commit f3f17ba into main Aug 30, 2023
@Arlodotexe Arlodotexe deleted the fix/assets/png-files branch August 30, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working enhancement New feature or request sample app 🖼 Uno Issues related to Uno Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some sample assets not showing in UWP
2 participants