Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample App] Non-WASM supported components showing up in WASM Sample App #5

Closed
1 of 20 tasks
michael-hawker opened this issue Mar 13, 2023 · 0 comments · Fixed by #141
Closed
1 of 20 tasks

[Sample App] Non-WASM supported components showing up in WASM Sample App #5

michael-hawker opened this issue Mar 13, 2023 · 0 comments · Fixed by #141
Assignees
Labels
bug 🐛 Something isn't working sample app 🖼 source generator ⚙️ Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces

Comments

@michael-hawker
Copy link
Member

Describe the bug

Components like Shimmer which use composition and aren't supported in WASM, have a Multi-target that defines as such. However, it's still appearing in the WASM sample app when generating the all solution.

This is tangentially related to the local component head for WASM being copied as well when it's not supported (not sure if we have another issue for that, maybe want a separate one?).

Steps to reproduce

1. GenerateAllSolution
2. Run WASM head
3. Open controls, see Shimmer
4. Click on Shimmer
5. See error in output as Shimmer page doesn't exist for WASM, shouldn't be listed in app.

Expected behavior

Shimmer not shown in WASM app head.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@michael-hawker michael-hawker added bug 🐛 Something isn't working Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces sample app 🖼 source generator ⚙️ labels Mar 13, 2023
@Arlodotexe Arlodotexe transferred this issue from CommunityToolkit/Labs-Windows Mar 15, 2023
@michael-hawker michael-hawker moved this from 📋 Backlog to 🔖 Ready in Toolkit 8.x Apr 19, 2023
@Arlodotexe Arlodotexe moved this from 🔖 Ready to 🏗 In progress in Toolkit 8.x May 31, 2023
@Arlodotexe Arlodotexe self-assigned this May 31, 2023
@Arlodotexe Arlodotexe moved this from 🏗 In progress to 🔖 Ready in Toolkit 8.x May 31, 2023
@michael-hawker michael-hawker moved this from 🔖 Ready to 🏗 In progress in Toolkit 8.x Sep 19, 2023
Arlodotexe added a commit that referenced this issue Sep 19, 2023
@Arlodotexe Arlodotexe moved this from 🏗 In progress to 👀 In review in Toolkit 8.x Sep 21, 2023
Arlodotexe added a commit that referenced this issue Sep 29, 2023
* Added AddMultiTargetCompatibleSampleDocs target.
Fixes #5.

* Fixed a lowercase T

* Fixed target execution order

* Use RoslynCodeTaskFactory

* Fix typo

* Fixed MultiTarget Identifiers
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Toolkit 8.x Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working sample app 🖼 source generator ⚙️ Uno Issues related to Uno Platform WASM Bugs related to working with WASM/Codespaces
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants