Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up: Remove custom content linking and SourceAssets folder for loading of Sample Code, XAML, and Markdown #18

Open
michael-hawker opened this issue Jun 6, 2022 · 2 comments
Assignees
Labels
build 🔥 enhancement New feature or request external ⤴️ Requires an update to an external dependency or due to code outside the Toolkit. Uno Issues related to Uno Platform

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Jun 6, 2022

Related CommunityToolkit/Labs-Windows#37, CommunityToolkit/Labs-Windows#88

Improvement to workaround for this Uno issue: unoplatform/uno#8618 - If the Uno issue gets resolved, this work doesn't need to be done and we can clean-up our existing workaround in the codebase.

@Arlodotexe talked to Jerome. He suggested instead of the glob we could use an inline task to help us with our desired copying heuristic: https://github.com/unoplatform/uno/blob/43efd99f67daade2e663e317989c3ab324a2c443/src/SolutionTemplate/Uno.ProjectTemplates.Dotnet/Uno.ProjectTemplates.Dotnet.csproj#L244

That way we can use the proper globs to grab the input files from the proper locations, but then have the task make sure the extra parent/relative path parts don't matter as it'll copy it to a consistent SourceAssets\ExperimentName.Sample\files location which matches the metadata we generate. That way all the apps should be able to load consistently regardless of where we're building the app / grabbing the files from, right?

Originally posted by @michael-hawker in CommunityToolkit/Labs-Windows#130 (comment)

@michael-hawker michael-hawker added enhancement New feature or request Uno Issues related to Uno Platform build 🔥 labels Jun 6, 2022
Arlodotexe referenced this issue in CommunityToolkit/Labs-Windows Jun 6, 2022
@michael-hawker michael-hawker added the external ⤴️ Requires an update to an external dependency or due to code outside the Toolkit. label Jun 14, 2022
@Arlodotexe
Copy link
Member

This has been implemented in Uno. A workaround is no longer needed

@michael-hawker michael-hawker changed the title Clean-up: Use Custom MSBuild Task to map Content Recursion Clean-up: Remove custom content linking and SourceAssets folder for loading of Sample Code, XAML, and Markdown Mar 2, 2023
@Arlodotexe Arlodotexe self-assigned this Mar 3, 2023
@michael-hawker
Copy link
Member Author

Another reason to work to fix this is that it's broken for individual experiment document viewing:

image

(i.e. everything I think is working when you compile the all solution, but if you just build an individual experiment and view the document preview in WASM, then it fails...)

@Arlodotexe Arlodotexe transferred this issue from CommunityToolkit/Labs-Windows Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 🔥 enhancement New feature or request external ⤴️ Requires an update to an external dependency or due to code outside the Toolkit. Uno Issues related to Uno Platform
Projects
Status: 📋 Backlog
Status: In Progress
Development

No branches or pull requests

2 participants