-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing source file assets on some samples #134
Conversation
This has been tested on UWP and Wasm. Wasdk still needs testing, I ran into issues getting it to launch on my machine. |
That fixed the Headered control ones, but the behaviors are still broken: Probably because they're in a sub-directory for organization: (Same with the ConstrainedBox samples.) Suppose we should just flatten them for now? 😟 Would be nice to support folders for samples as Behaviors, Primitives, the Extensions are all larger projects. Is there a better way we can think to test and validate this setup moving forward too? |
I guess we just flatten them for now? There's not many options in terms of finding the subfolder path of a xaml or cs file. |
Had a thought during lunch and came to a realization why this There's a couple of issues with different causes:
Going to test this out now by adjusting the namespaces of these three sets of samples. |
… app We should think of making an analyzer to detect this, since we use it... See discussion here about this issue: CommunityToolkit/Tooling-Windows-Submodule#134 (comment)
Fixed in CommunityToolkit/Windows#214 now! 🎉🎉🎉 No tooling changes required, going to close this. |
… app We should think of making an analyzer to detect this, since we use it... See discussion here about this issue: CommunityToolkit/Tooling-Windows-Submodule#134 (comment)
… app We should think of making an analyzer to detect this, since we use it... See discussion here about this issue: CommunityToolkit/Tooling-Windows-Submodule#134 (comment)
This PR fixes an issue where the
.xaml
and.cs
source files were failing to load in-app for some samples.Related #18