New <MultiTarget> system, added multitarget-aware ProjectReference generator #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultitargeting (WIP)
Arlodotexe
added
the
dev loop ➰
|
Draft PR. Working in MSBuild, not yet working in Visual Studio. |
common/MultiTarget/MultiTargetAwareProjectReference.props.template
Outdated
Show resolved
Hide resolved
|
Not sure what happened here: |
|
We should include something for documentation in this PR before closing. |
michael-hawker
previously requested changes
Dec 13, 2022
There was a problem hiding this comment.
Think we're still missing the targetframework modification aspect of this? As well as some issues on WASM/Skia/Uno for netstandard still being generated/included for samples?
Otherwise, glad it's mostly self-contained, but think there's still a bit of clean-up/streamlining we can do.
…ding, causing defaults to always be used
Arlodotexe
dismissed
michael-hawker’s stale review
Requested changes complete, reviewer is gone for the week.
niels9001
approved these changes
Dec 20, 2022
Arlodotexe
added a commit
to Avid29/Labs-Windows
that referenced
this pull request
Dec 21, 2022
Arlodotexe
added a commit
to arcadiogarcia/Labs-Windows
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
./common/.MultiTarget.propsfile found alongside a discovered project. Scans an array of folders, and generates a conditional project reference that only activates when the referenced project supports a MultiTarget that the referencing project uses.Closes #298