Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocking to allow to get tokens #41

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

sswguo
Copy link
Member

@sswguo sswguo commented Dec 15, 2022

There is client.getTokens().await().indefinitely(); which includes the method await(), and that is not allowed in event-loop, adding annotation blocking to make it work and we may need to figure out the better way for this.

Ref: quarkusio/quarkus#13835

@sswguo sswguo requested review from ligangty and ruhan1 December 15, 2022 08:57
@ruhan1
Copy link
Contributor

ruhan1 commented Dec 15, 2022

can we make the initial getTokens as a PostConstruction of CustomClientRequestFilter?

@sswguo
Copy link
Member Author

sswguo commented Dec 15, 2022

can we make the initial getTokens as a PostConstruction of CustomClientRequestFilter?

it may still happen when it is expired.

@ruhan1
Copy link
Contributor

ruhan1 commented Dec 15, 2022

+1
Adding the @Blocking is the right way. It will tell backend code to handle it as a blocking method.

Copy link
Contributor

@ruhan1 ruhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sswguo sswguo merged commit 58b4d8e into Commonjava:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants