Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java Flight Recorder event for JaxRS requests. #41

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

whitingjr
Copy link

Add Flight Recorder event.

@ruhan1
Copy link
Contributor

ruhan1 commented Jan 27, 2021

Do we also call FlightRecorder.register(JaxRSEvent.class) somewhere? I see some doc said so.

@whitingjr
Copy link
Author

whitingjr commented Jan 27, 2021

Do we also call FlightRecorder.register(JaxRSEvent.class) somewhere? I see some doc said so.

I'll add a class to register the event on Startup.

@whitingjr
Copy link
Author

whitingjr commented Jan 27, 2021

I was wondering if you had any Exception Handler plan ?
The FlightRecorderFilter is sensitive to having a JaxRS Exception Handler configured. Without it then when an unhandled exception is thrown then ContainerResponseFilter.filter is not called. The event is never committed.
What I'll do is add handlers to make the application robust for these events.

@ruhan1
Copy link
Contributor

ruhan1 commented Jan 28, 2021

wrt exception handlers, I guess there is sth by default? sometimes I see when exception occurs, the gateway handles it quite well. anyway, this pr looks good and I'll merge it. thanks.

@ruhan1 ruhan1 merged commit 50ecb65 into Commonjava:master Jan 28, 2021
@whitingjr
Copy link
Author

I read that dev mode in quarkus causes the exception to be handled. Whereas running normally means an exception is handled by a configured ExceptionMapper or not (ugly stacktrace).

@whitingjr whitingjr deleted the add-jfr-events branch January 28, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants