-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[landing] Reduce code duplication in landing/siwe.react.js
Summary: This code is completely duplicated from `lib/utils/wagmi-utils.js`. Test Plan: 1. In my local environment, make sure that mobile SIWE still works with Rainbow wallet (mobile SIWE uses `landing`, but web SIWE doesn't) 2. In combination with other diffs in the stack, I tested the following on both my local environment, and in a staging environment for my keyserver on comm.domains: - Mobile sign in with Rainbow wallet using Rainbow login - Mobile sign in with Rainbow wallet using WalletConnect login - Web sign in with Rainbow wallet using Rainbow login - Web sign in with Rainbow wallet using WalletConnect login - Web sign in with Metamask wallet Reviewers: rohan, atul, ginsu Reviewed By: atul Subscribers: tomek, wyilio Differential Revision: https://phab.comm.dev/D9432
- Loading branch information
Showing
2 changed files
with
8 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters