Skip to content

Commit

Permalink
[nix] Update dev-shell.nix with comment on SystemConfiguration
Browse files Browse the repository at this point in the history
Summary:
The reqwest requires the SystemConfiguration which is not available in the MacOS linker.

This adds a reminder comment to our nix shell to remove the SystemConfiguration dependency when the reqwest issue is resolved:
seanmonstar/reqwest#2006 (comment)

Test Plan: Successfully ran `nix develop`

Reviewers: ashoat, varun, O1 Nix

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D10668
  • Loading branch information
wyilio committed Jan 18, 2024
1 parent 8179b46 commit 0107bf1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions nix/dev-shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ mkShell {
CoreFoundation
CoreServices
Security
# required until https://github.com/seanmonstar/reqwest/issues/2006 is resolved
SystemConfiguration
libiconv # identity service
]);
Expand Down

0 comments on commit 0107bf1

Please sign in to comment.