New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Remove beforeunload handler - unusable in electron #2318

Merged

huchenlei merged 1 commit into main from fix-desktop-cannot-close

Jan 22, 2025

Contributor

webfiltered commented Jan 22, 2025 •

edited by sync-by-unito bot

Loading

Resolves [Bug]: ComfyUI 0.4.12 is freezed after installing a custom node and pressing the restart button desktop#688
Introduced in [Settings] Enable Comfy.Window.UnloadConfirmation by default #2258
Removes the beforeunload component when using the desktop app - this API is non-functional in Electron and has never worked there
This feature will be added for the desktop app separately

┆Issue is synchronized with this Notion page by Unito


          Remove beforeunload handler - unusable in electron

f42f2ea

webfiltered requested a review from a team as a code owner

January 22, 2025 19:34

huchenlei approved these changes

View reviewed changes

huchenlei merged commit 8cfc1c4 into main

10 checks passed

huchenlei deleted the fix-desktop-cannot-close branch

January 22, 2025 20:35

huchenlei added the Electron label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels