N°7995 - Allow to redefine portal twig template for all bricks in a portal #686
+57
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Objective
When redefining a brick template, you need to overload the
<template>
for every brick definition.It works well for one specific iTop, but as we plan to release an extension bringing the 3.3.0 portal design compatible with iTop 3.2.1+, we need to be able to overload templates for all bricks in a portal without overloading every brick definition
Proposed solution
This pull request use the
<template>
defined in the portal properties, allowing it to define new default templates that bricks will take into account if they do not have a specific template in their definition.Example of a customization that'll affect every BrowseBrick in a portal:
Checklist before requesting a review