Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

27 confirm email address after registration #46

Merged
merged 40 commits into from
Feb 9, 2023
Merged

27 confirm email address after registration #46

merged 40 commits into from
Feb 9, 2023

Conversation

JustLime
Copy link
Collaborator

@JustLime JustLime commented Feb 2, 2023

No description provided.

@JustLime JustLime linked an issue Feb 2, 2023 that may be closed by this pull request
Confirm email address after registration #27
Closed
@JustLime JustLime self-assigned this Feb 2, 2023
tbsvttr
tbsvttr requested changes Feb 3, 2023
View reviewed changes
.env.development Outdated Show resolved Hide resolved
.env.test Outdated Show resolved Hide resolved
app/controllers/users/confirmations_controller.rb Outdated Show resolved Hide resolved
app/controllers/users/registrations_controller.rb Outdated Show resolved Hide resolved
app/controllers/users/registrations_controller.rb Outdated Show resolved Hide resolved
spec/support/helpers/spa_helper.rb Outdated Show resolved Hide resolved
spec/system/spa_spec.rb Outdated Show resolved Hide resolved
spec/system/workflow_admin_spec.rb Show resolved Hide resolved
app/javascript/components/ConfirmationError.tsx Outdated Show resolved Hide resolved
app/javascript/components/NotFound.tsx Outdated Show resolved Hide resolved
JustLime added 18 commits February 6, 2023 11:52
@JustLime
Move confirmation of User in system spec into factory
cfac2a9
@JustLime
Remove unnecessary code in registrations_controller.rb
72d2ce7
@JustLime
Move comment to right place
6595404
@JustLime
Add spec to check if time is in period
16c6493
@JustLime
Move one line method to endless style
131b71e
@JustLime
Change User.first with memoized helper
118cc89
@JustLime
Fix routing
5b8c299
@JustLime
Add confirmed User to factory
f66d3b7
@JustLime
Set confirmation period back to 3 days
03d0114
@JustLime
Replace text for notification
bf85cd1
@JustLime
Enforce types for React JSX components
4f6d4ef
@JustLime
Fix bug where tracking item selection did not work
237532d
@JustLime
Make env variables more consistent
ec17c94
@JustLime
Change env values, also change Devise config and add routes plus specs
541c21b
@JustLime
Overwrite Devise controller and mailer view
1326e71
@JustLime
Add password reset and password change screen
0042c5b
@JustLime
Add env for password reset mail view
d30afa6
@JustLime
Add specs for Users::PasswordsController
b0b3c77
tbsvttr
tbsvttr requested changes Feb 9, 2023
View reviewed changes
.env.test Outdated Show resolved Hide resolved
app/controllers/users/confirmations_controller.rb Outdated Show resolved Hide resolved
app/javascript/components/NewPassword.tsx Outdated Show resolved Hide resolved
app/javascript/components/new-password/PasswordChangeErrorResult.tsx Outdated Show resolved Hide resolved
app/javascript/components/new-password/PasswordChangeSuccessfulResult.tsx Outdated Show resolved Hide resolved
app/javascript/components/registration/ConfirmationSuccessful.tsx Outdated Show resolved Hide resolved
app/javascript/components/smart-table/AutoCompleteSearch.tsx Show resolved Hide resolved
config/environments/production.rb Outdated Show resolved Hide resolved
config/environments/test.rb Outdated Show resolved Hide resolved
spec/requests/users/passwords_controller_spec.rb Show resolved Hide resolved
tbsvttr
tbsvttr requested changes Feb 9, 2023
View reviewed changes
app/javascript/components/new-password/NewPasswordErrorResult.tsx Outdated Show resolved Hide resolved
app/javascript/components/new-password/NewPasswordForm.tsx Outdated Show resolved Hide resolved
app/javascript/components/password-reset/PasswordResetForm.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tbsvttr
tbsvttr approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@tbsvttr tbsvttr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tbsvttr tbsvttr merged commit 314df10 into develop Feb 9, 2023
@tbsvttr tbsvttr deleted the 27-confirm-email-address-after-registration branch February 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbsvttr tbsvttr tbsvttr approved these changes

Assignees

@JustLime JustLime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm email address after registration
2 participants
@JustLime @tbsvttr