Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Jupyter notebook example #65

Merged
merged 20 commits into from
May 11, 2020
Merged

docs: add Jupyter notebook example #65

merged 20 commits into from
May 11, 2020

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented May 8, 2020

Currently only added a notebook that illustrates how to generate data samples, but this can be extended by simply adding more notebooks in the examples/jupyter folder.

Current output on RTD can be viewed at
https://pwa.readthedocs.io/projects/tensorwaves/en/notebooks/usage.html

@redeboer redeboer added 📝 Docs Improvements or additions to documentation Priority: High labels May 8, 2020
@redeboer redeboer requested a review from spflueger May 8, 2020 15:05
@redeboer redeboer self-assigned this May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #65 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   58.03%   57.95%   -0.09%     
==========================================
  Files          13       13              
  Lines         510      509       -1     
==========================================
- Hits          296      295       -1     
  Misses        214      214              
Impacted Files Coverage Δ
tensorwaves/data/tf_phasespace.py 96.15% <ø> (-0.15%) ⬇️

@redeboer
Copy link
Member Author

redeboer commented May 8, 2020

Changing this PR back to draft status, because I can't get nbsphinx to work properly...

@redeboer
Copy link
Member Author

Notebook output seems to render correctly now on RTD
https://pwa.readthedocs.io/projects/tensorwaves/en/notebooks/usage/generate.html

Only Travis is complaining now...

.travis.yml Outdated Show resolved Hide resolved
doc/intensity-recipe.yaml Outdated Show resolved Hide resolved
examples/jupyter/generate.ipynb Outdated Show resolved Hide resolved
examples/jupyter/generate.ipynb Outdated Show resolved Hide resolved
examples/python/workflow.py Show resolved Hide resolved
doc/conf.py Show resolved Hide resolved
Copy link
Member

@spflueger spflueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@redeboer redeboer merged commit b346f5e into master May 11, 2020
@redeboer redeboer deleted the notebooks branch May 11, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants