-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bs5 Components #5312
Bs5 Components #5312
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I added the Bootstrap color loop into _toasts.scss. Never did that before. I had to add a function though to get the subtle bg color. Is there any easier way (e.g. build a variable from a variable)? |
|
Make PR commit readable https://www.youtube.com/watch?v=gXCkYkLQ3To |
Sorry, but I don't know how or maybe I am misunderstanding. How do create a separate JS file and make sure it ends up in the
|
@glewe I'm going to make some changes to the code. Please don't push anything |
Ok. Thanks. |
In dark mode toast is not good, any idea @glewe |
I have pushed some code @glewe |
I think the colors are ok. They match the BS colors. The only thing that does not work well is the filter for the close button SVG. Therefore, the following changes need to be applied to the
In order for that to work, the default toast DOM object must get the class
|
Thanks. I pulled your changes and updated my local branch. |
pushed code, please upstream |
The current code includes a Forms => General Elements page that shows basic Bootstrap 5 form elements.
In this PR I added a Components => General Components page showing basic Bootstrap 5 components.
(I also used this branch to fix some minor things in the form elements page.)