Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select2 input:focus border #1549

Closed
ajcastro opened this issue Jun 23, 2017 · 9 comments
Closed

select2 input:focus border #1549

ajcastro opened this issue Jun 23, 2017 · 9 comments

Comments

@ajcastro
Copy link

ajcastro commented Jun 23, 2017

Duplicate of #756. Since it was already closed, I will open a new issue for this. @almasaeed2010

It is because of the width set to the element. Maybe there is a jquery code that add the width to 519px.

image

If you uncheck the width css, it is fine:

image

@ajcastro
Copy link
Author

Possible css fix, via chrome dev tools only to give you hints. @almasaeed2010

image

image

@ajcastro
Copy link
Author

But the css above has also a problem. When it is applied, the input element will be always on the next line.
Maybe it is better if we remove the border on the input element.

image

almasaeed2010 added a commit that referenced this issue Jun 24, 2017
@almasaeed2010
Copy link
Contributor

Fixed in master (v2.4)

Thanks for detailed report and help @ajcastro!!

@ajcastro
Copy link
Author

You're Welcome! Happy to contribute. 😊

@almasaeed2010
Copy link
Contributor

Here is how it looks now
screen shot 2017-06-24 at 11 09 57 am

Please let me know if that's not how you see it in your browser

@ajcastro
Copy link
Author

ajcastro commented Jun 25, 2017

That design looks perfect!
But I visited https://adminlte.io/themes/AdminLTE/pages/forms/advanced.html and it looks like this.

image

@almasaeed2010
Copy link
Contributor

@ajcastro please try clearing your browser cache and test again because it looks fine in my browser.
The only difference is that you are using chrome on Windows and I am using Mac so that might be causing the difference. Lastly, the width is apparently calculated via select2's JS. So, if the issue persists, please try upgrading to the latest select2 plugin (which we are planning to do for v2.4-beta-2).

Thanks!

@ajcastro
Copy link
Author

Yeah, it's now perfect! 🍷

@AiltonOcchi
Copy link

I add this code in AdminLte.css
.select2-selection--single:focus
{border: 1px solid #3c8dbc;}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants