Skip to content
Qodana for Pull Request

[BEEG CHANGES] HoYoPlay API Adjustments #203

Sign in to view logs

[BEEG CHANGES] HoYoPlay API Adjustments

[BEEG CHANGES] HoYoPlay API Adjustments #203

GitHub Actions / Qodana for .NET completed May 24, 2024 in 0s

243 new problems found by Qodana for .NET

Qodana for .NET

75 new problems were found

Inspection name Severity Problems
Conditional access qualifier expression is known to be null or not null 🔶 Warning 11
'??' condition is known to be null or not null 🔶 Warning 10
Possible 'System.NullReferenceException' 🔶 Warning 10
Explicit delegate creation expression is redundant 🔶 Warning 7
Redundant using directive 🔶 Warning 6
Unused local variable 🔶 Warning 5
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 4
Assignment is not used 🔶 Warning 3
Virtual member call in constructor 🔶 Warning 3
Possible 'null' assignment to non-nullable entity 🔶 Warning 2
Async function without await expression 🔶 Warning 2
Redundant empty object or collection initializer 🔶 Warning 2
Redundant control flow jump statement 🔶 Warning 2
Do not use object initializer for 'using' variable 🔶 Warning 2
Access to disposed captured variable 🔶 Warning 1
Async method invocation without await expression 🔶 Warning 1
Invalid XML documentation comment 🔶 Warning 1
Mismatch of optional parameter value in overridden method 🔶 Warning 1
Redundant 'base.' qualifier 🔶 Warning 1
Variable in local function hides variable from outer scope 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 100 dependencies

Third-party software list

This page lists the third-party software dependencies used in CollapseLauncher

Dependency Version Licenses
Clowd.Squirrel 2.11.1 MIT
CommunityToolkit.Common 8.2.2 MIT
CommunityToolkit.Mvvm 8.2.2 MIT
CommunityToolkit.WinUI.Animations 8.0.240109 MIT
CommunityToolkit.WinUI.Behaviors 8.0.240109 MIT
CommunityToolkit.WinUI.Controls.ImageCropper 8.1.240328-rc MIT
CommunityToolkit.WinUI.Controls.Primitives 8.0.240109 MIT
CommunityToolkit.WinUI.Controls.SettingsControls 8.0.240109 MIT
CommunityToolkit.WinUI.Controls.Sizers 8.0.240109 MIT
CommunityToolkit.WinUI.Converters 8.0.240109 MIT
CommunityToolkit.WinUI.Extensions 8.1.240328-rc MIT
CommunityToolkit.WinUI.Helpers 8.0.240109 MIT
CommunityToolkit.WinUI.Media 8.0.240109 MIT
CommunityToolkit.WinUI.Triggers 8.0.240109 MIT
GitInfo 3.3.5 MIT
Google.Protobuf.Tools 3.26.1 PROTOBUF
Google.Protobuf 3.26.1 BSD-3-Clause
Google.Protobuf 3.27.0 BSD-3-Clause
H.GeneratedIcons.System.Drawing 2.0.131 MIT
H.NotifyIcon.WinUI 2.0.131 MIT
H.NotifyIcon 2.0.131 MIT
Hi3Helper.ZstdNet 1.5.3 BSD-3-Clause
HtmlAgilityPack 1.11.61 MIT
ImageEx 2.1.1 MIT
Markdig.Signed 0.37.0 BSD-2-Clause
Microsoft.CSharp 4.7.0 MIT
Microsoft.Graphics.Win2D 1.2.0 MS-ASP-NET-WEB-OPTIMIZATION
Microsoft.NET.ILLink.Tasks 8.0.5 MIT
Microsoft.NETCore.Platforms 8.0.0-preview.7.23375.6 MIT
Microsoft.NETCore.Targets 6.0.0-preview.4.21253.7 MIT
Microsoft.Win32.Registry 5.0.0 MIT
Microsoft.Win32.SystemEvents 8.0.0 MIT
Microsoft.Windows.SDK.BuildTools 10.0.22621.3233 PROPRIETARY-LICENSE
Microsoft.WindowsAppSDK 1.5.240428000 MIT
MS-DXSDK-D3DX-9.29.952.3
Microsoft.Xaml.Behaviors.WinUI.Managed 2.0.9 MIT
PhotoSauce.MagicScaler 0.14.2 MIT
PhotoSauce.NativeCodecs.Libwebp 1.3.2-preview3 MIT
Roman-Numerals 2.0.0 MIT
SharpCompress 0.37.2 MIT
SharpHDiffPatch.Core 2.2.5 MIT
System.Collections.Concurrent 4.3.0 MS-NET-LIBRARY-2019-06
System.Collections 4.3.0 MS-NET-LIBRARY-2019-06
System.Diagnostics.Debug 4.3.0 MS-NET-LIBRARY-2019-06
System.Diagnostics.DiagnosticSource 4.3.0 MS-NET-LIBRARY-2019-06
System.Diagnostics.EventLog 8.0.0 MIT
System.Diagnostics.Tracing 4.3.0 MS-NET-LIBRARY-2019-06
System.Drawing.Common 8.0.5 MIT
System.Globalization.Calendars 4.3.0 MS-NET-LIBRARY-2019-06
System.Globalization.Extensions 4.3.0 MS-NET-LIBRARY-2019-06
System.Globalization 4.3.0 MS-NET-LIBRARY-2019-06
System.IO.FileSystem.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.IO.FileSystem 4.3.0 MS-NET-LIBRARY-2019-06
System.IO.Hashing 8.0.0 MIT
System.IO 4.3.0 MS-NET-LIBRARY-2019-06
System.Linq 4.3.0 MS-NET-LIBRARY-2019-06
System.Net.Http 4.3.4 MS-NET-LIBRARY-2019-06
System.Net.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.Reflection.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.Reflection 4.3.0 MS-NET-LIBRARY-2019-06
System.Resources.ResourceManager 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.Extensions 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.Handles 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.InteropServices 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime.Numerics 4.3.0 MS-NET-LIBRARY-2019-06
System.Runtime 4.3.1 MS-NET-LIBRARY-2019-06
System.Security.AccessControl 6.0.1 MIT
System.Security.Cryptography.Algorithms 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Cng 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Csp 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Encoding 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.OpenSsl 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.Primitives 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Cryptography.X509Certificates 4.3.0 MS-NET-LIBRARY-2019-06
System.Security.Principal.Windows 5.0.0 MIT
System.Text.Encoding.CodePages 8.0.0 MIT
System.Text.Encoding 4.3.0 MS-NET-LIBRARY-2019-06
System.Text.Encodings.Web 8.0.0 MIT
System.Text.Json 8.0.3 MIT
System.Text.RegularExpressions 4.3.1 MS-NET-LIBRARY-2019-06
System.Threading.Tasks.Extensions 4.5.4 MIT
System.Threading.Tasks 4.3.0 MS-NET-LIBRARY-2019-06
System.Threading 4.3.0 MS-NET-LIBRARY-2019-06
TaskScheduler 2.11.0 MIT
ThisAssembly.Constants 1.4.1 MIT
ZstdSharp.Port 0.8.1 MIT
runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.native.System.Net.Http 4.3.0 MS-NET-LIBRARY-2019-06
runtime.native.System.Security.Cryptography.Apple 4.3.0 MS-NET-LIBRARY-2019-06
runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.native.System 4.3.0 MS-NET-LIBRARY-2019-06
runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple 4.3.0 MS-NET-LIBRARY-2019-06
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl 4.3.2 MS-NET-LIBRARY-2019-06
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 65 in Hi3Helper.Sophon.Test/Program.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 383 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 404 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity 

Possible 'null' assignment to non-nullable entity

Check warning on line 242 in CollapseLauncher/Classes/InstallManagement/Genshin/GenshinSophonInstall.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Async function without await expression 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 236 in CollapseLauncher/Classes/InstallManagement/Genshin/GenshinSophonInstall.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Async function without await expression 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 65 in Hi3Helper.Sophon.Test/Program.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Async method invocation without await expression 

Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.

Check warning on line 106 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations 

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 262 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations 

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 314 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations 

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 312 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is not null according to nullable reference types' annotations 

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 158 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2430 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 112 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2145 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2390 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 223 in CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2145 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 69 in CollapseLauncher/Classes/Helper/Animation/AnimationHelper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2412 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 76 in CollapseLauncher/Classes/Helper/Animation/AnimationHelper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2412 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Conditional access qualifier expression is known to be null or not null 

Conditional access qualifier expression is known to be not null

Check warning on line 2390 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

'??' condition is known to be null or not null 

'??' left operand is never null

Check warning on line 2430 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

'??' condition is known to be null or not null 

'??' left operand is never null

Check warning on line 2430 in CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

'??' condition is known to be null or not null 

'??' left operand is never null

Check warning on line 76 in Hi3Helper.Sophon/Helper/TaskExtensions.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

'??' condition is known to be null or not null 

'??' left operand is never null
View more details on GitHub Actions