Qodana #72
807 new problems found by Qodana for .NET
Qodana for .NET
807 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Possible 'System.NullReferenceException' |
🔶 Warning | 97 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 66 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 60 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 37 |
Assignment is not used |
🔶 Warning | 27 |
Invalid XML documentation comment |
🔶 Warning | 26 |
Expression is always 'true' or always 'false' |
🔶 Warning | 25 |
Redundant catch clause |
🔶 Warning | 25 |
Virtual member call in constructor |
🔶 Warning | 23 |
Redundant class or interface specification in base types list |
🔶 Warning | 21 |
Unused local variable |
🔶 Warning | 18 |
Missing grid column/row setter for non-first child |
🔶 Warning | 18 |
Parameter hides member |
🔶 Warning | 17 |
Incorrect indent (around child statement) |
🔶 Warning | 16 |
Return value of [MustUseReturnValue] annotated method is not used |
🔶 Warning | 16 |
Redundant control flow jump statement |
🔶 Warning | 15 |
Bitwise operation on enum is not marked by [Flags] attribute |
🔶 Warning | 13 |
Unsafe context declaration is redundant |
🔶 Warning | 13 |
Redundant type declaration body |
🔶 Warning | 11 |
Cannot resolve symbol in text argument |
🔶 Warning | 10 |
Possible 'System.InvalidOperationException' |
🔶 Warning | 10 |
Underlying type of enum is 'int' |
🔶 Warning | 9 |
Heuristically unreachable code |
🔶 Warning | 9 |
Non-readonly type member referenced in 'GetHashCode()' |
🔶 Warning | 9 |
Redundant 'base.' qualifier |
🔶 Warning | 9 |
Grid element column/row index is out of grid definition range |
🔶 Warning | 9 |
'??' condition is known to be null or not null |
🔶 Warning | 8 |
Empty general catch clause |
🔶 Warning | 8 |
Possible multiple enumeration |
🔶 Warning | 8 |
Redundant base constructor call |
🔶 Warning | 8 |
Redundant cast |
🔶 Warning | 8 |
Local variable hides member |
🔶 Warning | 7 |
Redundant lambda expression parameter type specification |
🔶 Warning | 7 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 7 |
Unused nullable directive |
🔶 Warning | 7 |
Conditional access qualifier expression is not null according to nullable reference types' annotations |
🔶 Warning | 6 |
Non-accessed local variable |
🔶 Warning | 6 |
Explicit delegate creation expression is redundant |
🔶 Warning | 6 |
Remove redundant attached property setter |
🔶 Warning | 6 |
Non-nullable member is uninitialized. |
🔶 Warning | 5 |
Possible overflow in unchecked context |
🔶 Warning | 5 |
Member initialized value ignored |
🔶 Warning | 5 |
Access to modified captured variable |
🔶 Warning | 4 |
Collection content is never queried (non-private accessibility) |
🔶 Warning | 4 |
Expression is always 'true' or 'false' according to nullable reference types' annotations |
🔶 Warning | 4 |
Redundant 'partial' modifier on type declaration |
🔶 Warning | 4 |
Possible loss of fraction |
🔶 Warning | 4 |
Redundant 'IEnumerable.Cast<T>' or 'IEnumerable.OfType<T>' call |
🔶 Warning | 4 |
Assignment in conditional expression |
🔶 Warning | 3 |
Collection content is never queried (private accessibility) |
🔶 Warning | 3 |
Use null check pattern instead of a type check succeeding on any not-null value |
🔶 Warning | 3 |
Possible unassigned object created by 'new' expression |
🔶 Warning | 3 |
Mismatch of optional parameter value in overridden method |
🔶 Warning | 3 |
Actual shift count equals zero |
🔶 Warning | 3 |
Variable in local function hides variable from outer scope |
🔶 Warning | 3 |
Call to base member with implicit default parameters |
🔶 Warning | 2 |
Possible null reference return. |
🔶 Warning | 2 |
Possible unintended reference comparison |
🔶 Warning | 2 |
Private field can be converted into local variable |
🔶 Warning | 2 |
Redundant explicit type in array creation |
🔶 Warning | 2 |
Redundant type arguments of method |
🔶 Warning | 2 |
String.IndexOf is culture-specific (string.IndexOf(string) is culture-specific) |
🔶 Warning | 2 |
Do not use object initializer for 'using' variable |
🔶 Warning | 2 |
Property value is equal to style-provided |
🔶 Warning | 2 |
Access to disposed captured variable |
🔶 Warning | 1 |
Access to a static member of a type via a derived type |
🔶 Warning | 1 |
Avoid using 'async' lambda when delegate type returns 'void' |
🔶 Warning | 1 |
A possible null value may not be used for a type marked with [NotNull] or [DisallowNull]. |
🔶 Warning | 1 |
Cannot convert null literal to non-nullable reference type. |
🔶 Warning | 1 |
Check dependency licenses |
🔶 Warning | 1 |
Co-variant array conversion |
🔶 Warning | 1 |
Empty constructor |
🔶 Warning | 1 |
String formatting method problems |
🔶 Warning | 1 |
Method with optional or 'params' parameter is hidden by overload |
🔶 Warning | 1 |
Non-accessed field |
🔶 Warning | 1 |
Non-accessed field (private accessibility) |
🔶 Warning | 1 |
Operator 'is'/'Type Of ... Is ...' can be used |
🔶 Warning | 1 |
Parameter output value is always discarded (private accessibility) |
🔶 Warning | 1 |
Redundant 'partial' modifier on method declaration |
🔶 Warning | 1 |
The source expression always matches the provided pattern |
🔶 Warning | 1 |
Redundant 'Attribute' suffix |
🔶 Warning | 1 |
Redundant 'case' label |
🔶 Warning | 1 |
Redundant nullable directive |
🔶 Warning | 1 |
Redundant 'string.Format()' call |
🔶 Warning | 1 |
Redundant nullable warning suppression expression |
🔶 Warning | 1 |
Redundant 'object.ToString()' call |
🔶 Warning | 1 |
Return value of pure method is not used |
🔶 Warning | 1 |
Constant shift expression with non-zero operands results in a zero value |
🔶 Warning | 1 |
String.LastIndexOf is culture-specific (string.LastIndexOf(string) is culture-specific) |
🔶 Warning | 1 |
Method return value is never used (private accessibility) |
🔶 Warning | 1 |
Variable can be declared as non-nullable |
🔶 Warning | 1 |
Redundant resource |
🔶 Warning | 1 |
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 750 in CollapseLauncher/Classes/Interfaces/Class/ProgressBase.cs
github-actions / Qodana for .NET
Access to disposed captured variable
Captured variable is disposed in the outer scope
Check warning on line 154 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 156 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 155 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 162 in CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/SimpleDialogs.cs
github-actions / Qodana for .NET
Access to modified captured variable
Captured variable is modified in the outer scope
Check warning on line 199 in CollapseLauncher/XAMLs/Updater/Classes/Updater.cs
github-actions / Qodana for .NET
Access to a static member of a type via a derived type
Access to a static member of a type via a derived type
Check warning on line 88 in CollapseLauncher/Classes/InstallManagement/Genshin/GenshinInstall.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 296 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 23 in CollapseLauncher/Classes/GameManagement/GameSettings/Genshin/Settings.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 34 in CollapseLauncher/Classes/GameManagement/GameSettings/Honkai/Settings.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 253 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 408 in CollapseLauncher/Classes/RepairManagement/StarRail/Fetch.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 120 in CollapseLauncher/Classes/ShortcutCreator/SteamShortcut.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 119 in CollapseLauncher/Classes/InstallManagement/GameConversionManagement.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 95 in Hi3Helper.EncTool/Parser/Proto/src/StarRailDispatchStatic.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 110 in CollapseLauncher/Classes/RepairManagement/Genshin/Check.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 211 in Hi3Helper.EncTool/Parser/Proto/src/StarRailDispatchStatic.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 37 in CollapseLauncher/XAMLs/Invoker/Classes/Migrate.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity
Check warning on line 87 in CollapseLauncher/Classes/RepairManagement/StarRail/Repair.cs
github-actions / Qodana for .NET
Possible 'null' assignment to non-nullable entity
Possible 'null' assignment to non-nullable entity