Stable 1.82.10 Hotfix #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a75f61a.
This method should be more efficient and less to cause errors, especially when handling floating numbers with problems like: NaN, divided by zero, Infinity and out-of-range seconds to TimeSpan conversion
100% reviewed source file: 'en_US.json' on 'ja_JP'.
100% reviewed source file: 'en_US.json' on 'zh_CN'.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SentryHelper.ExceptionHandler(ex, SentryHelper.ExceptionType.UnhandledOther); | ||
| // If failed, flag ErrorOccured as true and skip the source directory deletion | ||
| LogWriteLine($"Error while deleting source directory \"{directoryInfoSource.FullName}\"\r\nException: {ex}", LogType.Error, true); | ||
| errorOccured = true; |
Check warning
Code scanning / QDNET
Assignment is not used Warning
| @@ -389,10 +390,18 @@ | |||
| basePath = Path.GetDirectoryName(filePath); | |||
| baseName = Path.GetFileNameWithoutExtension(filePath); | |||
|
|
|||
| // Get directory base info. If it doesn't exist, return | |||
| DirectoryInfo basePathDirInfo = new DirectoryInfo(basePath); | |||
Check warning
Code scanning / QDNET
Possible 'null' assignment to non-nullable entity Warning
| @@ -472,6 +472,16 @@ | |||
| Grid thisIconText = (Grid)thisCheckBox?.FindDescendant("IconText"); | |||
| if (thisIconText != null) | |||
| thisIconText.Opacity = 1; | |||
|
|
|||
| RadioButton thisRadioButton = thisCheckBox.Parent as RadioButton; | |||
Check warning
Code scanning / QDNET
Possible 'System.NullReferenceException' Warning
neon-nyan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new? - 1.82.10
NullReferenceExceptioncrash caused by nullvoice_packsproperty, by @neon-nyanSharingViolationexceptions onInstallManagerBase, by @neon-nyanDirectoryNotFoundExceptionon HSR's Game Repair ->RemoveHashMarkFile()method, by @neon-nyanChangelog Prefixes