-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Zenless Zone Zero Support #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ also moving its interfaces to the base class instead, including IGameSettings and IGameSettingsUniversal
CollapseLauncher/Classes/InstallManagement/BaseClass/InstallManagerBase.cs
Fixed
Show fixed
Hide fixed
CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs
Fixed
Show fixed
Hide fixed
CollapseLauncher/Classes/Helper/LauncherApiLoader/HoYoPlay/HoYoPlayLauncherApiLoader.cs
Fixed
Show fixed
Hide fixed
CollapseLauncher/Classes/GameManagement/GameVersion/Zenless/VersionCheck.cs
Fixed
Show fixed
Hide fixed
CollapseLauncher/Classes/GameManagement/GameVersion/Zenless/VersionCheck.cs
Fixed
Show fixed
Hide fixed
neon-nyan
added
Area: Preset Config
Issue labeled for Preset/Region Configuration
Game: Zenless Zone Zero
Issue labeled for Zenless Zone Zero
Area: Runtime
Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse
Area: Launcher
Issue labeled for Launcher update mechanism
Area: UI/UX
Issue labeled for User Interface/eXperience related issue
Enhancement
New feature or request
labels
Jun 28, 2024
Will fix the warnings later, I'm eepy right now |
HoYoPlayGameInfoField? sophonLauncherGameInfoRoot = new HoYoPlayGameInfoField(); | ||
if (hypLauncherGameInfo != null) | ||
{ | ||
ConvertGameInfoResources(ref sophonLauncherGameInfoRoot, hypLauncherGameInfo?.GameInfoData); |
Check warning
Code scanning / QDNET
Conditional access qualifier expression is known to be null or not null Warning
Conditional access qualifier expression is known to be not null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Launcher
Issue labeled for Launcher update mechanism
Area: Preset Config
Issue labeled for Preset/Region Configuration
Area: Runtime
Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse
Area: UI/UX
Issue labeled for User Interface/eXperience related issue
Enhancement
New feature or request
Game: Zenless Zone Zero
Issue labeled for Zenless Zone Zero
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
As the title said, the PR brings support for the newest HoYo's title, Zenless Zone Zero.
This PR contains some runtime changes that's required in order to support the initial preload on the pre-release date.
What's Changed?
RegionClasses
GameSettings
properties toSettingsBase
.InitializeSettings()
intoIGameSettings
Interface.NullReferenceException
throw if someGamePreset
andGameSettings
values are null.PR Status :
Templates
Changelog Prefixes