[BEEG CHANGES] HoYoPlay API Adjustments #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new ILauncherApi to unify the integration with other types of API (like: HoYoPlay)
+ Borrowing HSR version check and game settings for now.
This was causing some installation detection issues where some region/version check related string is falsely detected as Base64 and make the string rendered incorrectly
+ Also fixes throw while checking for non-existence pre-load property
Adding USENEWZIPDECOMPRESS to use SharpCompress decompressor with multi-thread zip decompress support.
100% reviewed source file: 'en_US.json' on 'id_ID'.
+ Adding FontSize property to the CompressedTextBlock + Unify ApplyShadow to be used by other elements, moving the code to UIElementExtensions with some changes. + Adding StartAnimationDetached to AnimationHelper extension + Adjust element sizes on both Normal and Small Size window + Minor adjustment on brushes + Move the playtme button beside the Quick Settings and Community Tools button + Adding shadows to navigation menu icons (by: @shatyuka) and social media icons + New layout and adjustments for Carousel and News panel + Adjustment on Install, Update and Start game button + Adding loading animation while loading ImageEx element Co-Authored-By: Shatyuka <[email protected]>
100% reviewed source file: 'en_US.json' on 'id_ID'.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
QDNET found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
THANKS MICROSOFT VERY COOL This hopefully fixes #445
wrong commit hash 😓
bagusnl
added a commit
that referenced
this pull request
May 25, 2024
* [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * FIx background handler getting disposed on MainPage reload * Fix region combobox cannot receive input while reloading MainPage * (GSP-SR) Clamp ShadowQuality value #399 * Icon button adjustment margin, alignment, size, glyph, etc * [i18n] Localize metadata initialization messages also for game region combobox placeholder * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * (GSP-SR) Clamp all quality values * (GSP-SR) GraphicsQuality presets * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * (GSP-SR) Fix fullscreen inconsistency * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Sync translation Translate en_US.json in id_ID 100% reviewed source file: 'en_US.json' on 'id_ID'. * Adding Async JSONSerializer helper for Stream * Use nullable assignment for game package return list * Update stamp file instead of redownloading if certain config has changed * Update SharpDiscordRPC submodule * Adjustment on CDN RadioButtons style * Adjustment on CDN RadioButtons style (pt. 2) * (GSP) Fix resolution related crash in RDP session * (CodeQA) ISULR - Suppress warnings - Reformat - Adjust nullables * Update EncTool * [skip ci] Update Checkout CI and add PR template * [skip ci] Update formatting error on PR template * Add ``PreventSleep()`` to prevent Windows' sleep routine Co-Authored-By: Bagus Nur Listiyono <[email protected]> * (GSP) Fix root cause of resolution related crash in RDP session * Implement PreventSleep() on needed methods * (GSP) Implement mobile layout mode Only for GI for now * (GSP) Add delay game launch function on pre launch command * Dont catch cancellation exception on PreventSleep * Show nav sidebar only on hover * Add drop shadow to nav button * (HI3 Repair) Throw if asset key is not found * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * Add MobileLayout support for StarRail #466 Thanks for the details @ubdjshdb * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [HSR Settings] Update localization text for 120FPS option selector * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * [skip ci] Sync translation Translate en_US.json in id_ID 100% reviewed source file: 'en_US.json' on 'id_ID'. * [skip ci] Sync translation Translate en_US.json in id_ID 100% reviewed source file: 'en_US.json' on 'id_ID'. * HoYoPlay API Adjustments (#465) * Change EncTool path * Use async stream for loading background files * Fix escaped JSON characters don't get parsed correctly * Move constant JSON class into inner extension class * Refactor API Loaders Using the new ILauncherApi to unify the integration with other types of API (like: HoYoPlay) * Adding basic HYP to Sophon pkg resource conversion + Borrowing HSR version check and game settings for now. * Adding background image support for HoYoPlay API * Adding news and carousel panel support for HoYoPlay API * Fix false Base64 detection on ``GetServeV3String()`` This was causing some installation detection issues where some region/version check related string is falsely detected as Base64 and make the string rendered incorrectly * Fix some typo and avoid unnecessary buffer alloc on ``ServeV3Data`` + Also fixes throw while checking for non-existence pre-load property * Fix crash while changing launcher release channel * Fix background throw due to null preload property * Adding new decompressor for .zip package files Adding USENEWZIPDECOMPRESS to use SharpCompress decompressor with multi-thread zip decompress support. * Avoid null packages to be proceeded * Check availability for cache type: "Event" with DLM = 2 * Fix Hi3 Game Repair for version: ``Thelema`` * Re-adding checks if the normal metadata file exists (Hi3) * FIx "Check Update" button status's center position * Adjust windows title-bar button style * Extend maximum threads for download to 16 * Fix TextFillColorBrush on update status button * Use GetURLStatusCode to check URL status on repair/cache * Use ``Enum.GetValues<T>()`` instead of ``Enum.GetValues(typeof(T))`` * Fix last exception in ``RetryTimeoutAfter()`` not getting thrown * Fix threading issues on Install, Repair and Cache mechanism * Fix Infinity and NaN numbers in ``TotalPerfileProgress`` * Use ``UnNaNInfinity()`` in ``UpdateProgress()`` * Fix data corruption while performing game data migration * Fix max session exception on Hi3Helper.Http * Fix float/double to TimeSpan number conversion This due to the number being a negative infinity * Bump version * Add Sophon submodule * FIx background handler getting disposed on MainPage reload * Fix region combobox cannot receive input while reloading MainPage * Adding Sophon testing/usage sample * Adding Async JSONSerializer helper for Stream * Use nullable assignment for game package return list * Update stamp file instead of redownloading if certain config has changed * Update SharpDiscordRPC submodule * Adding Sophon submodule and its testing project * Add new Sophon Chunk download mechanism * (GSP-SR) Clamp ShadowQuality value #399 * [i18n] Localize metadata initialization messages also for game region combobox placeholder * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * (GSP-SR) Clamp all quality values * (GSP-SR) GraphicsQuality presets * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * Localize Discord RPC Game/Region strings * Add a way to skip audio patch Currently only for Star Rail * (CDN) Add Coding mirror * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * Update NuGet Dependencies H.NotifyIcon https://www.nuget.org/packages/H.NotifyIcon.WinUI#releasenotes-body-tab HtmlAgilityPack https://github.com/zzzprojects/html-agility-pack/releases/tag/v1.11.61 WASDK https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/stable-channel#version-153-15240428000 TaskScheduler https://github.com/dahall/TaskScheduler/releases/tag/v2.11.0 * Update NuGet * Fix build configuration * Adjustment on CDN RadioButtons style * Adjustment on CDN RadioButtons style (pt. 2) * (GSP-SR) Fix fullscreen inconsistency * Update sophon submodule * Update sophon submodule * Add ``PreventSleep()`` to prevent Windows' sleep routine Co-Authored-By: Bagus Nur Listiyono <[email protected]> * [TaskExtensions] Throw inner exception if completed task is faulty * [HYP] Add parser for social media icons * [Sophon] Fix crash caused by empty URL conditions in news API * [UI] Adjust the social media flyout style * Implement PreventSleep() on needed methods * Update GitInfo NuGet and package lock file * [TaskExtensions] Use the new ``WaitForRetryAsync`` for retrying task * [UI] Fix inconsistent foreground color for socmed's QR title * (GSP) Implement mobile layout mode Only for GI for now * (GSP) Add delay game launch function on pre launch command * Update submodules and NuGet * Use custom style for ``ImageEx`` * Remove unnecessary ``Console.WriteLine()`` under ``CurrentMetadataConfig`` * Use custom style for ``ImageEx`` pt. 2 * Use async WriteLine for logger (also uses .Error and .Out to write) * Hi3Helper.Sophon adjustment * Dont catch cancellation exception on PreventSleep * Show nav sidebar only on hover * Add drop shadow to nav button * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * Update Hi3Helper.Http submodule * Fix fallback translation for MobileLayout text * [skip ci] Sync translation Translate en_US.json in id_ID 100% reviewed source file: 'en_US.json' on 'id_ID'. * Remove deprecated CDN (Bitbucket) * UI Adjustments + Adding FontSize property to the CompressedTextBlock + Unify ApplyShadow to be used by other elements, moving the code to UIElementExtensions with some changes. + Adding StartAnimationDetached to AnimationHelper extension + Adjust element sizes on both Normal and Small Size window + Minor adjustment on brushes + Move the playtme button beside the Quick Settings and Community Tools button + Adding shadows to navigation menu icons (by: @shatyuka) and social media icons + New layout and adjustments for Carousel and News panel + Adjustment on Install, Update and Start game button + Adding loading animation while loading ImageEx element Co-Authored-By: Shatyuka <[email protected]> * [skip ci] Sync translation Translate en_US.json in id_ID 100% reviewed source file: 'en_US.json' on 'id_ID'. * Remove unnecessary Lottie package * Adjust Preload box dialog UI * Use current thread for animation compositor * Adjust preload button style to ``AcrylicButtonStyle`` * Use current thread for animation compositor (pt. 2) * Add 500 ms delay before side panel animation is triggered * Fix crash on starting animation with no access to thread * Minor adjustment on loading frame * Fix task not retrying due to cancellation from linked source * Fix retry mechanism on API loading not working * Adjust DisconnectedPage style * Add HoYoPlay featured event icon and styles * Fix installation progress bar style * Update sophon and HYP install mechanism * fix typo * change insufficient drive space dialog required type * fix incorrect package size indicators to the user THANKS MICROSOFT VERY COOL This hopefully fixes #445 * update submodule * update submodule wrong commit hash 😓 --------- Co-authored-by: Kemal Setya Adhi <[email protected]> Co-authored-by: Shatyuka <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Ron Friedman <[email protected]> --------- Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Kemal Setya Adhi <[email protected]> Co-authored-by: Shatyuka <[email protected]> Co-authored-by: Ron Friedman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
PR Status :
Templates
Changelog Prefixes