Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GI Dynamic Character Resolution #388

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

shatyuka
Copy link
Contributor

@shatyuka shatyuka commented Feb 5, 2024

Add a corresponding checkbox to Genshin Impact settings page.

@shatyuka shatyuka added Game: Genshin Impact Issue labeled for Genshin Impact Area: UI/UX Issue labeled for User Interface/eXperience related issue Area: Game Settings Issue labeled for Game Settings related issues labels Feb 5, 2024
@shatyuka shatyuka requested a review from bagusnl February 5, 2024 04:04
@shatyuka shatyuka self-assigned this Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking a bit of time, but all changes looks good and ready for merging~

@bagusnl
Copy link
Member

bagusnl commented Feb 6, 2024

As its only 1 commit I'll be merging by rebase

Note: This PR will be cherry picked to stable as without it, GSP will wipe the key 21 settings
Thank you for your work! <3

@bagusnl bagusnl merged commit 9f754dc into main Feb 6, 2024
4 checks passed
@shatyuka shatyuka deleted the dynamic-character-resolution branch February 7, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Game Settings Issue labeled for Game Settings related issues Area: UI/UX Issue labeled for User Interface/eXperience related issue Game: Genshin Impact Issue labeled for Genshin Impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants