Resizable Game Window

[neon-nyan]

What's new?

This PR brings the "Resizable Window" which enables the Game Window to be resizable. This feature could only work on Windowed mode (not including borderless).

This feature works by using Win32 functions by manipulating the game window's GWL_STYLE flag.
https://learn.microsoft.com/en-us/windows/win32/winmsg/window-styles

Behavior Changes

For Honkai: Star Rail

"Use Custom Resolution" mode can only be used with "Resizable Window" enabled. If the "Resizable Window" is disabled, the checkbox for "Use Custom Resolution" will be disabled.

Feature Preview

2024-01-27.17-29-21.mp4

[github-actions]

Qodana for .NET

180 new problems were found

Inspection name	Severity	Problems
Virtual member call in constructor	🔶 Warning	21
Invalid XML documentation comment	🔶 Warning	17
Bitwise operation on enum is not marked by [Flags] attribute	🔶 Warning	13
Redundant catch clause	🔶 Warning	10
Return value of [MustUseReturnValue] annotated method is not used	🔶 Warning	9
Assignment is not used	🔶 Warning	9
Unused local variable	🔶 Warning	8
Possible 'null' assignment to non-nullable entity	🔶 Warning	7
Possible 'System.NullReferenceException'	🔶 Warning	6
Redundant base constructor call	🔶 Warning	6
Possible overflow in unchecked context	🔶 Warning	5
Non-accessed local variable	🔶 Warning	5
Redundant 'base.' qualifier	🔶 Warning	5
Expression is always 'true' or always 'false'	🔶 Warning	4
'??' condition is known to be null or not null	🔶 Warning	4
Parameter hides member	🔶 Warning	4
Redundant name qualifier	🔶 Warning	4
Redundant type declaration body	🔶 Warning	4
Unsafe context declaration is redundant	🔶 Warning	4
Redundant using directive	🔶 Warning	4
Underlying type of enum is 'int'	🔶 Warning	3
Heuristically unreachable code	🔶 Warning	3
RoslynAnalyzers 'this' argument does not satisfy 'DynamicallyAccessedMembersAttribute' in call to target method. The generic parameter of the source method or type does not have matching annotations.	🔶 Warning	3
Redundant cast	🔶 Warning	3
Redundant lambda expression parameter type specification	🔶 Warning	3
Use null check pattern instead of a type check succeeding on any not-null value	🔶 Warning	2
Member initialized value ignored	🔶 Warning	2
Mismatch of optional parameter value in overridden method	🔶 Warning	2
Check dependency licenses	🔶 Warning	1
Collection content is never queried (private accessibility)	🔶 Warning	1
Conditional access qualifier expression is not null according to nullable reference types' annotations	🔶 Warning	1
Empty general catch clause	🔶 Warning	1
Non-accessed field (private accessibility)	🔶 Warning	1
Cannot resolve symbol in text argument	🔶 Warning	1
The source expression always matches the provided pattern	🔶 Warning	1
Redundant explicit type in array creation	🔶 Warning	1
Redundant control flow jump statement	🔶 Warning	1
Return value of pure method is not used	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[bagusnl]

Just a question regarding double invoke for the _Settings optimization

[bagusnl]

Looks all good to me!