Ab warning dialog #380
Merged
Ab warning dialog #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryotechnic
added
the
Area: Game Settings
Qodana for .NET1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
bagusnl
requested changes
Jan 26, 2024
|
Cryotechnic
added a commit
that referenced
this pull request
Feb 1, 2024
* move a/b code to hsr gsp & create new dialog type * Use ``MainWindow``'s ``XamlRoot`` for dialogs * Clean-up unused namespaces * updated locale * code cleanup * added nullable to registry a/b detection & typo fixes --------- Co-authored-by: Kemal Setya Adhi <[email protected]>
neon-nyan
added a commit
that referenced
this pull request
Feb 5, 2024
* move a/b code to hsr gsp & create new dialog type * Use ``MainWindow``'s ``XamlRoot`` for dialogs * Clean-up unused namespaces * updated locale * code cleanup * added nullable to registry a/b detection & typo fixes --------- Co-authored-by: Kemal Setya Adhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the warning dialog that would show if a specific registry key was detected, would show every time the region was loaded. This is now limited to only when the user opens the Honkai: Star Rail settings page, and will appear every time it is loaded.