Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Protocol support #368

Merged
merged 6 commits into from
Jan 13, 2024
Merged

URL Protocol support #368

merged 6 commits into from
Jan 13, 2024

Conversation

gablm
Copy link
Member

@gablm gablm commented Jan 13, 2024

  • Registers collapse:// as a URL protocol for Collapse

    • collapse://open -g 0 -r 1 == CollapseLauncher.exe open -g 0 -r 1
    • The protocol can be used through Win + R, .url files and web browsers
    • Only "tray" and "open" can be used, mainly for prevention of things like:
      <a href="collapse://movesteam">One Billion Free Primogems here!</a>
  • Fixes most "private" command line arguments not working.

Part of the process to implement #358 (2/3)

@gablm gablm added the Enhancement New feature or request label Jan 13, 2024
@gablm gablm added this to the 1.73.x milestone Jan 13, 2024
@gablm gablm self-assigned this Jan 13, 2024
Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code part looks good, just requesting changes for small codeQA issues

CollapseLauncher/Classes/Properties/AppActivation.cs Outdated Show resolved Hide resolved
CollapseLauncher/Classes/Properties/AppActivation.cs Outdated Show resolved Hide resolved
CollapseLauncher/Classes/Properties/ArgumentParser.cs Outdated Show resolved Hide resolved
@bagusnl
Copy link
Member

bagusnl commented Jan 13, 2024

Oki, everything looks good. Artifact tested locally and works as expected.

Thank you for your work <3!

Merging

@bagusnl bagusnl merged commit d34c247 into CollapseLauncher:main Jan 13, 2024
3 checks passed
@Cryotechnic Cryotechnic deleted the url-prot branch January 13, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants