Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for window maximize issue #319

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

shatyuka
Copy link
Contributor

Windows App SDK 1.4 introduces a new issue. Double-clicking on the title bar will maximize the window, ignoring IsMaximizable = false.
Temporary workaround: register the WndProc hook to filter out the WM_SYSCOMMAND SC_MAXIMIZE message.

microsoft/microsoft-ui-xaml#8666

@shatyuka shatyuka added Bug Something isn't working Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Nov 28, 2023
@shatyuka shatyuka requested a review from a team November 28, 2023 12:51
@bagusnl
Copy link
Member

bagusnl commented Nov 28, 2023

I think for this it was planned so that we also support maximized state. Though there were a problem where the drag area is quite messed up.

Will review this code in the meantime

Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code issues found, all good. Proceeding to merge by rebase

Thank you for your work!

Hi3Helper.Core/Classes/Data/InvokeProp.cs Show resolved Hide resolved
@bagusnl bagusnl merged commit 44dc80d into CollapseLauncher:main Nov 29, 2023
1 check passed
@neon-nyan neon-nyan added this to the v1.72.x milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI/UX Issue labeled for User Interface/eXperience related issue Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants