Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement News Panel and QR Code overview #10

Merged
merged 18 commits into from
Jun 21, 2022
Merged

Conversation

neon-nyan
Copy link
Member

@neon-nyan neon-nyan commented Jun 21, 2022

Overview

This pull request will introduce News Panel and QR Code Overview on HomePage for certain regions that support this feature like:

  • Mainland China (Honkai Impact 3rd CN Server) [News Feed & QR Code Overview]
  • Genshin Impact (Global Server) [News Feed Only]
  • 原神 / Yuan Shen (Mainland China's Genshin) [News Feed & QR Code Overview]

This PR is also replacing HTML based data with JSON based data for Resource Props, reducing the load time for some regions which don't need to parse/support the News Panel feature.
The News Feed Language will also matching the language used in the app (if applicable [For Example: Genshin Impact])

The API key in this PR has been updated to the latest version of the Official Launcher.

Feature Preview

Language Aware News Feed and Content

The content will be matching the language used in the app

News Feed and QR Code Overview in action

2022-06-21.20-56-46.mp4

@neon-nyan neon-nyan merged commit 87ed60d into main Jun 21, 2022
@neon-nyan neon-nyan deleted the newshighlight-panel branch June 21, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant